chore(op): type safety in computation of op tx metadata #10619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imism_rpc::OpEthApi
…pReceiptMetaBuilder
emhane
added
C-debt
emhane
requested review from
mattsse,
Rjected,
fgimenez,
onbjerg and
gakonst
as code owners
gakonst
reviewed
Aug 29, 2024
|
it wasn't possible for me to make a unit test for it before @gakonst , it was too confusing |
…th unmodified input from block scanner
…mxyz/reth into emhane/op-receipt-fields-builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up semantics from #10615 in a way that makes the logic understandable for non-original authors that aren't familiar with op data type intricacies.
reth_optimism_rpc::OpTxMetaasOpReceiptFieldsBuilder, which buildsop_alloy_rpc_types::OptimismTransactionReceiptFields